c# - Updating different Objects that have same properties -


in code, i've got 3 (or more...) different objects, have same properties (e.g. trackingitemtype, readerid etc).

they derived counterbase (which not have properties needed, others).

now want iterate through collection of objects. in collection, of 3 objects can occur. therefore, i've implemented "update" each object seperately.

question: how can avoid duplicate code written? there pattern available update different objects same properties?!

thanks!

method of interest: 

    private void updatetrackingcounters(reading readingdata, trackingitemtype trackingitemtype, string trackingcountertype)     {         try         {             foreach (counterbase counter in this.trackingcounters)             {                 if (typeof(trackingsimplecounter).isinstanceoftype(counter))                 {                     trackingsimplecounter trackingcounter = (trackingsimplecounter)counter;                      if (trackingcounter.trackingcountertype == trackingcountertype)                     {                         if ((trackingcounter.readerid == 0                             && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == 0                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             )                         {                             trackingcounter.increaseone();                         }                     }                 }                 else if (typeof(trackingintervalbasedrollingcounter).isinstanceoftype(counter))                 {                     trackingintervalbasedrollingcounter trackingcounter = (trackingintervalbasedrollingcounter)counter;                      if (trackingcounter.trackingcountertype == trackingcountertype)                     {                         if ((trackingcounter.readerid == 0                             && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == 0                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             )                         {                             trackingcounter.increaseone();                         }                     }                 }                 else if (typeof(trackingtriggerbasedrollingcounter).isinstanceoftype(counter))                 {                     trackingtriggerbasedrollingcounter trackingcounter = (trackingtriggerbasedrollingcounter)counter;                      if (trackingcounter.trackingcountertype == trackingcountertype)                     {                         if ((trackingcounter.readerid == 0                             && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == 0                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == null)                             || (trackingcounter.readerid == readingdata.readerid                                 && trackingcounter.trackingitemtype == trackingcounter.trackingitemtype)                             )                         {                             trackingcounter.increaseone();                         }                     }                 }             }         }         catch (exception ex)         {             this.trace.error(ex);         }     }

define interface contains properties , method need:

interface itrackable {     int readerid;     string trackingitemtype;     void increaseone(); }

and add declaration of each class has them:

class trackingsimplecounter : counterbase, itrackable  class trackingintervalbasedrollingcounter: counterbase, itrackable  class trackingtriggerbasedrollingcounter : counterbase, itrackable

if classes share properties, won't have implement of interface, since it'll present.

then need is

foreach (itrackable counter in this.trackingcounters) {     if ((counter.readerid == 0 && counter.trackingitemtype == null)     || (counter.readerid == 0 && counter.trackingitemtype == counter.trackingitemtype)     || (counter.readerid == readingdata.readerid && counter.trackingitemtype == null)     || (counter.readerid == readingdata.readerid && counter.trackingitemtype == counter.trackingitemtype)     )     {         counter.increaseone();     } }

although unless misunderstand logic need is:

foreach (itrackable counter in this.trackingcounters) {     if (counter.readerid == 0 || counter.readerid == readingdata.readerid)     {         counter.increaseone();     } }

or if want use linq:

foreach (var counter in this.trackingcounters.oftype<itrackable>().where(c => c.readerid == 0 || c.readerid = readingdata.readerid)) {     counter.increaseone(); }

Comments

Post a Comment

Popular posts from this blog

angular - Ionic slides - dynamically add slides before and after -

hi i'm using ngfor create set of 3 slides while starting in middle i'm guaranteed able slide left or right on start. when slide right can simple listen reachedend , push slide array i'm looping. but have problem adding slide beginning. if same above , use e.g. array.unshift() or spread add item beginning, view think it's on position 0 , snaps view new slide. the code below work animates slide change index 1. slide = [0,1,2] //example loop slidechanged(event) { if(this.slides.isbeginning()){ this.slide = [this.slide[0]-1, ...this.slide]; this.slides.update(); this.slides.slideto(1) } } <ion-slides [initialslide]="1" (ionslidedidchange)="slidechanged($event)"> <ion-slide *ngfor="let item of slide"> <h1>slide {{item}}</h1> </ion-slide> </ion-slides> any appreciated! you can using ionslidenextend , ionslideprevend events slides . please...
Read more

Add a dynamic header in angular 2 http provider -

i have http interceptor built via tutorial https://scotch.io/@kashyapmukkamala/using-http-interceptor-with-angular2 the problem need have dynamic header changes automatically once changes 'mode' in app. service able tell interceptor change header, or have interceptor pull header (which string)from service each request. able throwing away patch method, call http.patch('new header string') set header string. call in service controls 'mode' setting. wondering if there way interceptor pull recent value service each request or if can add method http provider via interceptor? i've tried call service in interceptor each request returns undefined. because creating new instance of service or copying value before service fired , loaded/changed data. i don't want pass header string every http provider call because defeats purpose of having interceptor, id able set once changes or have provider fetch service before makes request. tl;dr : need add autom...
Read more

minify - Minimizing css files -

i want know how css files can minimized. currently, using external sites css minifier compress css files. however, after removing whitespaces, comments, etc, file sizes reduced 10-15%. how frameworks bootstrap manage make minimized versions kilobytes. as example, css is: body { background-color: #ff0; } the reduction goes 28 bytes 22 bytes other css files have lot more characters still smaller this. actually minifying code means it's remove thing code white space characters new line characters comments block delimiters it reduces amount of code has transferred on web , speed site load fastly.but unreadable format.
Read more