php - Correct unit testing -


i started using unit , functionality test project , because of have questions:

im working symfony php framework. , have doctrine ldap orm service.

furthermore have user repository (as service) depends on ldap orm service, logger , validation service.

now want write unit test adduser function of userrepo. internally call: getnewuidnumber, usertoentities, doesuserexist , getuserbyuid.

my question is: should mock these internal function test adduser function? against unit test idea (just test api).

or should mock ldap orm service, logger, , validation service, class calls internal functions? cause huge test function lot of mocking because have mock repositories internal repositories calls.

or should start symfony kernel , use servicecontainer use orm ldap service real test database. wouldn't functionally test , not unit test? heard bad have many dependencies in test. thought bad use whole servicecontainer.

adduser:

public function adduser(user $user) {     $pbnlaccount = $this->usertoentities($user);      if(!$this->doesuserexist($user)) {         $pbnlaccount->setuidnumber($this->getnewuidnumber());         $this->ldapentitymanager->persist($pbnlaccount);         $this->ldapentitymanager->flush();     }     else {         throw new useralreadyexistexception("the user ".$user->getuid()." exists.");     }      return $this->getuserbyuid($user->getuid()); }

for more code, internal functions: https://gist.github.com/nkpmedia/4a6ee55b6bb96e8af409debd98950678

thanks paul

first, rewrite method tiny bit, if may.

public function adduser(user $user) {     if ($this->doesuserexist($user)) {         throw new useralreadyexistexception("the user ".$user->getuid()." exists.");     }      // ... shortened brevity     $pbnlaccount = $this->usertoentities($user);     $this->ldapentitymanager->persist($pbnlaccount); }

the other relevant method is: 

private function doesuserexist(user $user) {     $users = $this->ldaprepository->findbyuid($user->getuid());     return count($users) === 1; }

immediately can see have 2 tests:

  • we test method throws when user exists
  • we test method persists pbnlaccount if user does not exist.

if not see why have these 2 tests, note there 2 possible "flows" in method: 1 block inside if statement executed, , 1 not executed.

lets tackle first one:

public function testadduserthrowswhenuserexistsalready() {     $user = new user();     $user->setuid('123');      $ldaprepositorymock = $this->createmock(ldaprepository::class);     $ldaprepositorymock         ->method('findbyuid')         ->expects($this->once())         ->with('123')         ->willreturn(new pbnlaccount());      $userrepository = new userrepository($ldaprepositorymock);      $this->expectexception(useralreadyexistexception::class);     $userrepository->adduser($user);     }

the second test left exercise reader :)

yes will have mocking in case. wil need mock ldaprepository , ldapentitymanager both in case.

note 1: code not runnable, since not know exact details of code base (and wrote off top of head), beside point. point want test exception.

note 2: rename function createnewpbnlaccountforuser(user $user) longer, more descriptive of does.

note 3: not sure why returning $this->getuserbyuid() since seems redundant (you have user right there), ommitting case.


Comments

Post a Comment

Popular posts from this blog

angular - Ionic slides - dynamically add slides before and after -

hi i'm using ngfor create set of 3 slides while starting in middle i'm guaranteed able slide left or right on start. when slide right can simple listen reachedend , push slide array i'm looping. but have problem adding slide beginning. if same above , use e.g. array.unshift() or spread add item beginning, view think it's on position 0 , snaps view new slide. the code below work animates slide change index 1. slide = [0,1,2] //example loop slidechanged(event) { if(this.slides.isbeginning()){ this.slide = [this.slide[0]-1, ...this.slide]; this.slides.update(); this.slides.slideto(1) } } <ion-slides [initialslide]="1" (ionslidedidchange)="slidechanged($event)"> <ion-slide *ngfor="let item of slide"> <h1>slide {{item}}</h1> </ion-slide> </ion-slides> any appreciated! you can using ionslidenextend , ionslideprevend events slides . please...
Read more

Add a dynamic header in angular 2 http provider -

i have http interceptor built via tutorial https://scotch.io/@kashyapmukkamala/using-http-interceptor-with-angular2 the problem need have dynamic header changes automatically once changes 'mode' in app. service able tell interceptor change header, or have interceptor pull header (which string)from service each request. able throwing away patch method, call http.patch('new header string') set header string. call in service controls 'mode' setting. wondering if there way interceptor pull recent value service each request or if can add method http provider via interceptor? i've tried call service in interceptor each request returns undefined. because creating new instance of service or copying value before service fired , loaded/changed data. i don't want pass header string every http provider call because defeats purpose of having interceptor, id able set once changes or have provider fetch service before makes request. tl;dr : need add autom...
Read more

minify - Minimizing css files -

i want know how css files can minimized. currently, using external sites css minifier compress css files. however, after removing whitespaces, comments, etc, file sizes reduced 10-15%. how frameworks bootstrap manage make minimized versions kilobytes. as example, css is: body { background-color: #ff0; } the reduction goes 28 bytes 22 bytes other css files have lot more characters still smaller this. actually minifying code means it's remove thing code white space characters new line characters comments block delimiters it reduces amount of code has transferred on web , speed site load fastly.but unreadable format.
Read more