c++ - Why doesn't library source file include its header -


i trying explore opencv.

when looked mat class, can see defined in mat.hpp, located in include folder. however, when attempted search corresponding mat.cpp, found class definition located in matrix.cpp. suppose difference in file name not problem, long includes mat.hpp. however, header mat.hpp wasn't included either. know compiler still able compile, far know, bad programming practice.

so, question is, true bad practice not include header file in source file? there reason why should not included?

i understand not need explore detailed implementation of library, question out of curiosity.

here #include part of matrix.cpp

#include "precomp.hpp" #include "opencl_kernels_core.hpp" #include "bufferpool.impl.hpp"

and here #include part of mat.hpp

#include "opencv2/core/matx.hpp" #include "opencv2/core/types.hpp" #include "opencv2/core/bufferpool.hpp"

the short answer is: that's how project evolved.

the long answer is: opencv did (and still does) declare many of functions , classes in core.hpp while many .cpp files hold implementations. in case, matrix-specific functions (and implementations mat) in matrix.cpp , definitions classes, mat, in core.hpp.

as project grew, things seem split (probably easier manage). can see in this commit, class mat moved out of core.hpp own mat.hpp (named such match class name). source file matrix.cpp include mat.hpp, though indirectly (through precomp.hpp , core.hpp).

i don't think confusion intentional, incidental. bad practice? so, thats decide.

disclaimer: have not worked on opencv source, did use extensively time.


Comments

Post a Comment

Popular posts from this blog

angular - Ionic slides - dynamically add slides before and after -

hi i'm using ngfor create set of 3 slides while starting in middle i'm guaranteed able slide left or right on start. when slide right can simple listen reachedend , push slide array i'm looping. but have problem adding slide beginning. if same above , use e.g. array.unshift() or spread add item beginning, view think it's on position 0 , snaps view new slide. the code below work animates slide change index 1. slide = [0,1,2] //example loop slidechanged(event) { if(this.slides.isbeginning()){ this.slide = [this.slide[0]-1, ...this.slide]; this.slides.update(); this.slides.slideto(1) } } <ion-slides [initialslide]="1" (ionslidedidchange)="slidechanged($event)"> <ion-slide *ngfor="let item of slide"> <h1>slide {{item}}</h1> </ion-slide> </ion-slides> any appreciated! you can using ionslidenextend , ionslideprevend events slides . please...
Read more

Add a dynamic header in angular 2 http provider -

i have http interceptor built via tutorial https://scotch.io/@kashyapmukkamala/using-http-interceptor-with-angular2 the problem need have dynamic header changes automatically once changes 'mode' in app. service able tell interceptor change header, or have interceptor pull header (which string)from service each request. able throwing away patch method, call http.patch('new header string') set header string. call in service controls 'mode' setting. wondering if there way interceptor pull recent value service each request or if can add method http provider via interceptor? i've tried call service in interceptor each request returns undefined. because creating new instance of service or copying value before service fired , loaded/changed data. i don't want pass header string every http provider call because defeats purpose of having interceptor, id able set once changes or have provider fetch service before makes request. tl;dr : need add autom...
Read more

minify - Minimizing css files -

i want know how css files can minimized. currently, using external sites css minifier compress css files. however, after removing whitespaces, comments, etc, file sizes reduced 10-15%. how frameworks bootstrap manage make minimized versions kilobytes. as example, css is: body { background-color: #ff0; } the reduction goes 28 bytes 22 bytes other css files have lot more characters still smaller this. actually minifying code means it's remove thing code white space characters new line characters comments block delimiters it reduces amount of code has transferred on web , speed site load fastly.but unreadable format.
Read more