css - Grid-Media IN vs OUT -


me , coworker went eternal discussion best way use neat grid-medias.

consider following approuch:

approuch a:

.mydiv {   font-size: 14px;    @include grid-media($somegridvar) {     font-size: 18px;   } }

then, consider this:

approuch b:

.mydiv {   font-size: 14px; }  @include grid-media($somegridvar) {   .mydiv {     font-size: 18px;   } }

testing on neat, both approuchs renders same result, not put here because obvious.

my question is: prefer? there "better" approach suggested thoughtbot? there "better" approach suggested someone? there reason use 1 instead of other? matter of style? have use both provide enriched life statement?

what deduced till now:

in approuch a, have several includes of grid media on our pages, making code harder read , more bloated. @ other side, grid media centered in 1 single rule, , same rule not repeated on document each grid media.

in approuch b, have single block of each grid-media each breakpoint, resulting in shorter code, multiplying places element classes appear.

also, if coworker reading this, im looking forward discover way better. (yes, not tell one)

👋 hi!

i’ll preface saying code style team thing. works us, may not work you. above all, consistency , shared understanding matters. don’t spend time in weeds, little details. being said, (thoughtbot) publish our code style guides , prefer syntax (your ‘approach a’):

.mydiv {   font-size: 14px;    @include grid-media($somegridvar) {     font-size: 18px;   } }

why? mydiv thing you’re styling, not media query itself. encompassing styles relate selector within 1 declaration block provides lot of clarity. having styles affect selector spread out through multiple blocks can become hard decipher.


Comments

Post a Comment

Popular posts from this blog

angular - Ionic slides - dynamically add slides before and after -

hi i'm using ngfor create set of 3 slides while starting in middle i'm guaranteed able slide left or right on start. when slide right can simple listen reachedend , push slide array i'm looping. but have problem adding slide beginning. if same above , use e.g. array.unshift() or spread add item beginning, view think it's on position 0 , snaps view new slide. the code below work animates slide change index 1. slide = [0,1,2] //example loop slidechanged(event) { if(this.slides.isbeginning()){ this.slide = [this.slide[0]-1, ...this.slide]; this.slides.update(); this.slides.slideto(1) } } <ion-slides [initialslide]="1" (ionslidedidchange)="slidechanged($event)"> <ion-slide *ngfor="let item of slide"> <h1>slide {{item}}</h1> </ion-slide> </ion-slides> any appreciated! you can using ionslidenextend , ionslideprevend events slides . please
Read more

minify - Minimizing css files -

i want know how css files can minimized. currently, using external sites css minifier compress css files. however, after removing whitespaces, comments, etc, file sizes reduced 10-15%. how frameworks bootstrap manage make minimized versions kilobytes. as example, css is: body { background-color: #ff0; } the reduction goes 28 bytes 22 bytes other css files have lot more characters still smaller this. actually minifying code means it's remove thing code white space characters new line characters comments block delimiters it reduces amount of code has transferred on web , speed site load fastly.but unreadable format.
Read more

Add a dynamic header in angular 2 http provider -

i have http interceptor built via tutorial https://scotch.io/@kashyapmukkamala/using-http-interceptor-with-angular2 the problem need have dynamic header changes automatically once changes 'mode' in app. service able tell interceptor change header, or have interceptor pull header (which string)from service each request. able throwing away patch method, call http.patch('new header string') set header string. call in service controls 'mode' setting. wondering if there way interceptor pull recent value service each request or if can add method http provider via interceptor? i've tried call service in interceptor each request returns undefined. because creating new instance of service or copying value before service fired , loaded/changed data. i don't want pass header string every http provider call because defeats purpose of having interceptor, id able set once changes or have provider fetch service before makes request. tl;dr : need add autom
Read more