c++ - Qt Singleton implementation -


i looking singleton qt implementation , found this. have question it.

  1. what purpose of making create qbasicatomicpointer ?
  2. what point in qcallonce of using testandsetrelaxed if have used fetchandstoreacquire ? isn't acquire semantic preventing memory reordering after ?
  3. what purpose of qcallonceperthread function ? isn't qcallonce thread-safe ?

i copy contents of suggested implementation here:

call_once.h

#ifndef call_once_h #define call_once_h  #include <qtglobal> #include <qatomicint> #include <qmutex> #include <qwaitcondition> #include <qthreadstorage> #include <qthread>  namespace callonce {     enum ecallonce {         co_request,         co_inprogress,         co_finished     };      q_global_static(qthreadstorage<qatomicint*>, once_flag) }  template <class function> inline static void qcallonce(function func, qbasicatomicint& flag) {     using namespace callonce;  #if qt_version < 0x050000     int protectflag = flag.fetchandstoreacquire(flag); #elif qt_version >= 0x050000     int protectflag = flag.fetchandstoreacquire(flag.load()); #endif      if (protectflag == co_finished)         return;     if (protectflag == co_request && flag.testandsetrelaxed(protectflag,                                                            co_inprogress)) {         func();         flag.fetchandstorerelease(co_finished);     }     else {         {             qthread::yieldcurrentthread();         }         while (!flag.testandsetacquire(co_finished, co_finished));     } }  template <class function> inline static void qcallonceperthread(function func) {     using namespace callonce;     if (!once_flag()->haslocaldata()) {         once_flag()->setlocaldata(new qatomicint(co_request));         qcallonce(func, *once_flag()->localdata());     } }  #endif // call_once_h

singleton.h

#ifndef singleton_h #define singleton_h  #include <qtglobal> #include <qscopedpointer> #include "call_once.h"  template <class t> class singleton { private:   typedef t* (*createinstancefunction)(); public:   static t* instance(createinstancefunction create); private:   static void init();    singleton();   ~singleton();   q_disable_copy(singleton)   static qbasicatomicpointer<void> create;   static qbasicatomicint flag;   static qbasicatomicpointer<void> tptr;   bool inited; };  template <class t> t* singleton<t>::instance(createinstancefunction create) {   singleton::create.store(create);   qcallonce(init, flag);   return (t*)tptr.load(); }  template <class t> void singleton<t>::init() {   static singleton singleton;   if (singleton.inited) {     createinstancefunction createfunction = (createinstancefunction)singleton::create.load();     tptr.store(createfunction());   } }  template <class t> singleton<t>::singleton() {   inited = true; };  template <class t> singleton<t>::~singleton() {   t* createdtptr = (t*)tptr.fetchandstoreordered(nullptr);   if (createdtptr) {     delete createdtptr;   }   create.store(nullptr); }  template<class t> qbasicatomicpointer<void> singleton<t>::create = q_basic_atomic_initializer(nullptr); template<class t> qbasicatomicint singleton<t>::flag = q_basic_atomic_initializer(callonce::co_request); template<class t> qbasicatomicpointer<void> singleton<t>::tptr = q_basic_atomic_initializer(nullptr);  #endif // singleton_h

how use

// myclass.h  #ifndef myclass_h #define myclass_h  #include <qobject>  class myclass : public qobject {     q_object  private:     myclass(qobject* parent = 0);     static myclass* createinstance(); public:     ~myclass();     static myclass* instance(); };  #endif // myclass_h   // myclass.cpp  #ifndef myclass_h #define myclass_h  #include <qobject> #include "singleton.h"  myclass::myclass(qobject* parent):  qobject(parent) { }  myclass* myclass::createinstance() {     return new myclass(); }  myclass::~myclass() { }  myclass* myclass::instance() {     return singleton<myclass>::instance(myclass::createinstance); }  #endif // myclass_h

main.cpp

#include <qtextstream> #include "myclass.h"  #define myclassinstance singleton<myclass>::instance()  int main(int argc, char* argv[]) {     qtextstream(stdout) << myclass::instance()->metaobject()->classname() << endl;     return 0; }

i think enough use next singleton implementation. remember, c++11 gurantees there 1 instancing/initialization static variable. original problem in case, when more 1 thread tries access instance in same time , there possible situation, when singleton created twice.

template <typename t, typename d = t> class singleton {     friend d;     static_assert(std::is_base_of_v<t, d>, "t should base type d");  public:     static t& instance();  private:     singleton() = default;     ~singleton() = default;     singleton( const singleton& ) = delete;     singleton& operator=( const singleton& ) = delete; };  template <typename t, typename d> t& singleton<t, d>::instance() {     static d inst;     return inst; }  // usage: class myclass : public singleton<myclass> { public:     void foo(){} };  // access:  myclass::instance().foo();

Comments

Post a Comment

Popular posts from this blog

angular - Ionic slides - dynamically add slides before and after -

hi i'm using ngfor create set of 3 slides while starting in middle i'm guaranteed able slide left or right on start. when slide right can simple listen reachedend , push slide array i'm looping. but have problem adding slide beginning. if same above , use e.g. array.unshift() or spread add item beginning, view think it's on position 0 , snaps view new slide. the code below work animates slide change index 1. slide = [0,1,2] //example loop slidechanged(event) { if(this.slides.isbeginning()){ this.slide = [this.slide[0]-1, ...this.slide]; this.slides.update(); this.slides.slideto(1) } } <ion-slides [initialslide]="1" (ionslidedidchange)="slidechanged($event)"> <ion-slide *ngfor="let item of slide"> <h1>slide {{item}}</h1> </ion-slide> </ion-slides> any appreciated! you can using ionslidenextend , ionslideprevend events slides . please...
Read more

Add a dynamic header in angular 2 http provider -

i have http interceptor built via tutorial https://scotch.io/@kashyapmukkamala/using-http-interceptor-with-angular2 the problem need have dynamic header changes automatically once changes 'mode' in app. service able tell interceptor change header, or have interceptor pull header (which string)from service each request. able throwing away patch method, call http.patch('new header string') set header string. call in service controls 'mode' setting. wondering if there way interceptor pull recent value service each request or if can add method http provider via interceptor? i've tried call service in interceptor each request returns undefined. because creating new instance of service or copying value before service fired , loaded/changed data. i don't want pass header string every http provider call because defeats purpose of having interceptor, id able set once changes or have provider fetch service before makes request. tl;dr : need add autom...
Read more

minify - Minimizing css files -

i want know how css files can minimized. currently, using external sites css minifier compress css files. however, after removing whitespaces, comments, etc, file sizes reduced 10-15%. how frameworks bootstrap manage make minimized versions kilobytes. as example, css is: body { background-color: #ff0; } the reduction goes 28 bytes 22 bytes other css files have lot more characters still smaller this. actually minifying code means it's remove thing code white space characters new line characters comments block delimiters it reduces amount of code has transferred on web , speed site load fastly.but unreadable format.
Read more